Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438791
  
    --- Diff: src/include/catalog/pg_exttable.h ---
    @@ -164,9 +164,12 @@ GetExtTableEntry(Oid relid);
     extern void
     RemoveExtTableEntry(Oid relid);
     
    -#define CustomFormatType 'b'
    -#define TextFormatType 't'
    -#define CsvFormatType 'c'
    +#define CustomFormatType    'b'
    +#define TextFormatType      't'
    --- End diff --
    
    There should be no hard code format type in pluggable storage framwork


---

Reply via email to