[
https://issues.apache.org/jira/browse/HBASE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879139#action_12879139
]
HBase Review Board commented on HBASE-2670:
-------------------------------------------
Message from: st...@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/180/#review229
-----------------------------------------------------------
Ship it!
+1
I some minors in the below and then some questions but these should not get in
way of a commit.
src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/180/#comment1016>
Is this going to be correct always? Cloning, we don't want the src
memstoreTS?
src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/180/#comment1017>
What we going to do about N versions all of same r/f/q/ts but of different
memstoreTS? We're not going to suppress them just yet? We're going to punt
till hbase-1485? The multiple versions make it out to store files too?
src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java
<http://review.hbase.org/r/180/#comment1018>
Prefix w/ 'TODO' to make this work-to-do more findable.
src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java
<http://review.hbase.org/r/180/#comment1019>
Nice
src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
<http://review.hbase.org/r/180/#comment1020>
Go ahead and remove then boss.
- stack
> MemStore should retain multiple KVs with the same timestamp when memstoreTS
> differs
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2670
> URL: https://issues.apache.org/jira/browse/HBASE-2670
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.20.5, 0.21.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Blocker
> Attachments: hbase-2670.txt
>
>
> There appears to be a bug in HBASE-2248 as committed to trunk. See following
> failing test:
> http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1296/testReport/junit/org.apache.hadoop.hbase/TestAcidGuarantees/testAtomicity/
> Think this is the same bug we saw early on in 2248 in the 0.20 branch, looks
> like the fix didn't make it over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
