[ 
https://issues.apache.org/jira/browse/HBASE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879241#action_12879241
 ] 

HBase Review Board commented on HBASE-2670:
-------------------------------------------

Message from: st...@duboce.net


bq.  On 2010-06-15 18:06:09, Ryan Rawson wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/KeyValue.java, line 1306
bq.  > <http://review.hbase.org/r/180/diff/1/?file=1345#file1345line1306>
bq.  >
bq.  >     the extra KVs will make it out to hfile, but considering the problem 
I just don't see a better solution right now. Perhaps collapsing extra version 
during the flush, but then the question is _which_ extra versions?
bq.  >     
bq.  >     Maybe this will lead us to using an extra timestamp in every 
KeyValue on disk and in memory, but I hope not.

.bq ...but then the question is _which_ extra versions?

For now, I'd think we'd keep most recently written.

.bq Maybe this will lead us to using an extra timestamp in every KeyValue on 
disk and in memory

Maybe.  When we tease out deletes and how ts's are meant to work then we'll 
learn whether or not they are needed I'd imagine.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/180/#review235
-----------------------------------------------------------





> MemStore should retain multiple KVs with the same timestamp when memstoreTS 
> differs
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-2670
>                 URL: https://issues.apache.org/jira/browse/HBASE-2670
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.5, 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: hbase-2670.txt, hbase-2670.txt
>
>
> There appears to be a bug in HBASE-2248 as committed to trunk. See following 
> failing test:
> http://hudson.zones.apache.org/hudson/job/HBase-TRUNK/1296/testReport/junit/org.apache.hadoop.hbase/TestAcidGuarantees/testAtomicity/
> Think this is the same bug we saw early on in 2248 in the 0.20 branch, looks 
> like the fix didn't make it over.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to