[ 
https://issues.apache.org/jira/browse/HBASE-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886094#action_12886094
 ] 

Pranav Khaitan commented on HBASE-1517:
---------------------------------------

@Ryan, I was going through your code at 
http://github.com/ryanobjc/hbase/commit/0277ad862dc03c6513b08a99221fc5b2b6e61d57
 and had a question about the reseek functions you have added to 
StoreFileScanner. 

This reseek function is almost the same as the seek function except that it 
calls the reseek function of HFile instead of calling the seek function of 
HFile. This way we may need to add reseek functions to KeyValueHeap and 
StoreScanner also. I was thinking that an alternative to this would be to add a 
boolean argument to seek function which says if it is reseek or simply seek. 
Jonathan also suggested this since this would help us reduce duplicate code. 
What do you say?

> Implement inexpensive seek operations in HFile
> ----------------------------------------------
>
>                 Key: HBASE-1517
>                 URL: https://issues.apache.org/jira/browse/HBASE-1517
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: ryan rawson
>             Fix For: 0.21.0
>
>
> When we early-out of a row because of columns, versions, filters, etc... we 
> seek to the end of that row one key at a time.  We should do the seek at the 
> HFile level in cases where we would end up skipping blocks in the process.  
> This will be very common in cases with relatively large rows and regex row 
> filters.
> If calls that end up doing nothing are constant time, we could also call this 
> to seek to the next column (or even a specific column in ExplicitTracker 
> case).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to