[
https://issues.apache.org/jira/browse/HBASE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923314#action_12923314
]
HBase Review Board commented on HBASE-3082:
-------------------------------------------
Message from: thekhem...@facebook.com
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1053/
-----------------------------------------------------------
(Updated 2010-10-20 21:31:17.831889)
Review request for hbase and Jonathan Gray.
Changes
-------
I think I have taken care of all the review feedback
Summary
-------
Ensure that during incrementColumnValue() the scan triggered by the get() does
an early exit if it finds the KV in the memstore.
This addresses bug HBASE-3082.
http://issues.apache.org/jira/browse/HBASE-3082
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 0e3940c
src/main/java/org/apache/hadoop/hbase/regionserver/InternalScan.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 4775fc8
Diff: http://review.cloudera.org/r/1053/diff
Testing
-------
I have been testing it on my cluster. No unit testing yet.
Thanks,
khemani
> For ICV gets, first look in MemStore before reading StoreFiles
> --------------------------------------------------------------
>
> Key: HBASE-3082
> URL: https://issues.apache.org/jira/browse/HBASE-3082
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Jonathan Gray
> Assignee: Prakash Khemani
>
> For incrementColumnValue operations, it is possible to check MemStore for the
> column being incremented without sacrificing correctness. If the column is
> not found in MemStore, we would then have to do a normal Get that
> opens/checks all StoreFiles for the given Store.
> In practice, this makes increment operations significantly faster for
> recently/frequently incremented columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
