[ https://issues.apache.org/jira/browse/HBASE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924069#action_12924069 ]
HBase Review Board commented on HBASE-3082: ------------------------------------------- Message from: "Ryan Rawson" <ryano...@gmail.com> bq. On 2010-10-20 21:41:23, Ryan Rawson wrote: bq. > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java, line 155 bq. > <http://review.cloudera.org/r/1053/diff/2/?file=15063#file15063line155> bq. > bq. > Would this code be cleaner if we didnt have to use instanceof? bq. bq. khemani wrote: bq. yes, i agree it will be cleaner w/o instanceof. But in that case we will have to pass the flags all the way from HRegion to StoreScanner. A number of signatures will have to change. bq. bq. Another approach could be to only instantiate InternalScan in the server side. But again that is quite a bit of code change. bq. bq. Having an internal-scan should be useful. After all, a scan touches a lot of data and certain other tasks can potentially be piggybacked on a scan. ok that makes sense. let's go with it then. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1596 ----------------------------------------------------------- > For ICV gets, first look in MemStore before reading StoreFiles > -------------------------------------------------------------- > > Key: HBASE-3082 > URL: https://issues.apache.org/jira/browse/HBASE-3082 > Project: HBase > Issue Type: Improvement > Components: regionserver > Reporter: Jonathan Gray > Assignee: Prakash Khemani > > For incrementColumnValue operations, it is possible to check MemStore for the > column being incremented without sacrificing correctness. If the column is > not found in MemStore, we would then have to do a normal Get that > opens/checks all StoreFiles for the given Store. > In practice, this makes increment operations significantly faster for > recently/frequently incremented columns. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.