[
https://issues.apache.org/jira/browse/HBASE-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965309#action_12965309
]
HBase Review Board commented on HBASE-3287:
-------------------------------------------
Message from: st...@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1261/#review2009
-----------------------------------------------------------
Ship it!
Looks good to me. Some comments below.
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
<http://review.cloudera.org/r/1261/#comment6343>
This looks like useful addition.
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
<http://review.cloudera.org/r/1261/#comment6346>
Why the flush?
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
<http://review.cloudera.org/r/1261/#comment6344>
Does this create new byte array?
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
<http://review.cloudera.org/r/1261/#comment6345>
I wonder if we have to have full path here? Anything less could cause
clashes? But small optimization would strip the hbase.root at least?
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
<http://review.cloudera.org/r/1261/#comment6347>
Can you presize the BAOS? Whats the default? 4k? If so, and our default
block size is 64k, that'd be a bit of expensive array resizing going on? Just
guessing.
branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
<http://review.cloudera.org/r/1261/#comment6348>
Surround with if debug?
- stack
> Add option to cache blocks on hfile write and evict blocks on hfile close
> -------------------------------------------------------------------------
>
> Key: HBASE-3287
> URL: https://issues.apache.org/jira/browse/HBASE-3287
> Project: HBase
> Issue Type: Improvement
> Components: io, regionserver
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.92.0
>
>
> This issue is about adding configuration options to add/remove from the block
> cache when creating/closing files. For use cases with lots of flushing and
> compacting, this might be desirable to prevent cache misses and maximize the
> effective utilization of total block cache capacity.
> The first option, {{hbase.rs.cacheblocksonwrite}}, will make it so we
> pre-cache blocks as we are writing out new files.
> The second option, {{hbase.rs.evictblocksonclose}}, will make it so we evict
> blocks when files are closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
