[
https://issues.apache.org/jira/browse/HBASE-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965455#action_12965455
]
HBase Review Board commented on HBASE-3287:
-------------------------------------------
Message from: "Ryan Rawson" <ryano...@gmail.com>
bq. On 2010-11-30 09:57:27, Ryan Rawson wrote:
bq. > branches/0.90/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java,
line 765
bq. > <http://review.cloudera.org/r/1261/diff/1/?file=17902#file17902line765>
bq. >
bq. > why would you not want to evict blocks from the cache on close?
bq.
bq. stack wrote:
bq. I think this a good point. Its different behavior but its behavior we
should have always had? One less option too.
I'm still confused why we are adding config for something that we should always
be doing it. While we'll never be zero conf, I am not seeing the reason why
we'd want to keep things in the LRU.
It would make more sense not to evict on a split, but evict every other time,
since a split will probably reopen the same hfiles and need those blocks again.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1261/#review2010
-----------------------------------------------------------
> Add option to cache blocks on hfile write and evict blocks on hfile close
> -------------------------------------------------------------------------
>
> Key: HBASE-3287
> URL: https://issues.apache.org/jira/browse/HBASE-3287
> Project: HBase
> Issue Type: New Feature
> Components: io, regionserver
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.92.0
>
> Attachments: HBASE-3287-FINAL-trunk.patch
>
>
> This issue is about adding configuration options to add/remove from the block
> cache when creating/closing files. For use cases with lots of flushing and
> compacting, this might be desirable to prevent cache misses and maximize the
> effective utilization of total block cache capacity.
> The first option, {{hbase.rs.cacheblocksonwrite}}, will make it so we
> pre-cache blocks as we are writing out new files.
> The second option, {{hbase.rs.evictblocksonclose}}, will make it so we evict
> blocks when files are closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
