[
https://issues.apache.org/jira/browse/HBASE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965381#action_12965381
]
HBase Review Board commented on HBASE-3286:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jdcry...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1262/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Changes:
- In HMaster, instead of passing an IP as String we now pass the HSA object
completely.
- In HRegionServer, I cleared a bunch of crufty comments and handle the HSA
passed by the master.
- In HServerInfo, I saw that the hostname wasn't reset when setting the HSA.
Fixed.
- In HServerAddress, I fixed a few places that wasn't explicitly using
hostnames and changed the serialization to pass a hostname instead of an IP
address.
This addresses bug HBASE-3286.
http://issues.apache.org/jira/browse/HBASE-3286
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java 1040669
/trunk/src/main/java/org/apache/hadoop/hbase/HServerInfo.java 1040669
/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1040669
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1040669
Diff: http://review.cloudera.org/r/1262/diff
Testing
-------
Works on my MBP (I was seeing the same issue but since there's only 1 RS it
didn't have any bad effect) and my 10 machines Ubuntu cluster.
Thanks,
Jean-Daniel
> Master passes IP and not hostname back to region server
> -------------------------------------------------------
>
> Key: HBASE-3286
> URL: https://issues.apache.org/jira/browse/HBASE-3286
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> Starting my little test cluster on the latest from 0.90, I see:
> {noformat}
> 2010-11-29 23:21:34,131 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024
> region(s) across 9 server(s), retainAssignment=true
> 2010-11-29 23:21:34,134 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 22 region(s)
> to sv2borg181,61020,1291072886282
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 24 region(s)
> to sv2borg182,61020,1291072885473
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 37 region(s)
> to sv2borg183,61020,1291072885646
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 25 region(s)
> to sv2borg184,61020,1291072886734
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 26 region(s)
> to sv2borg185,61020,1291072886606
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 70 region(s)
> to sv2borg186,61020,1291072885486
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 30 region(s)
> to sv2borg187,61020,1291072886355
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 89 region(s)
> to sv2borg188,61020,1291072885926
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 701
> region(s) to sv2borg189,61020,1291072886739
> {noformat}
> After another restart:
> {noformat}
> 2010-11-30 00:03:38,100 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024
> region(s) across 9 server(s), retainAssignment=true
> 2010-11-30 00:03:38,103 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s)
> to sv2borg181,61020,1291075409984
> 2010-11-30 00:03:38,103 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 82 region(s)
> to sv2borg182,61020,1291075409956
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 61 region(s)
> to sv2borg183,61020,1291075409952
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 122
> region(s) to sv2borg184,61020,1291075409957
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 59 region(s)
> to sv2borg185,61020,1291075409955
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s)
> to sv2borg186,61020,1291075409963
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 52 region(s)
> to sv2borg187,61020,1291075411049
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 254
> region(s) to sv2borg188,61020,1291075410360
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 252
> region(s) to sv2borg189,61020,1291075409959
> {noformat}
> I also saw one time where everything was assigned to 189.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
