[
https://issues.apache.org/jira/browse/HBASE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965521#action_12965521
]
HBase Review Board commented on HBASE-3286:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jdcry...@apache.org>
bq. On 2010-11-30 12:27:06, Jonathan Gray wrote:
bq. > A little confused by the discrepancy between String host / int port and
the Address. But does seem fine given we don't actually access the string/int
values and always use the address object.
bq. >
bq. > Do we need some tests on this stuff? Seems like we always have issues
here but tests don't catch anything.
bq. >
bq. > Looks better than what we have though so I'm +1 regardless.
Regarding tests, I'm not sure what they would catch...
bq. On 2010-11-30 12:27:06, Jonathan Gray wrote:
bq. > /trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java, line 65
bq. > <http://review.cloudera.org/r/1262/diff/1/?file=17919#file17919line65>
bq. >
bq. > Why does stringValue not necessarily equal the host:port we store in
those Strings? Shouldn't they be the same?
I'm trying to keep it more consistent with the rest of the code, else when
looking at the code you ask yourself the question you just asked me :)
bq. On 2010-11-30 12:27:06, Jonathan Gray wrote:
bq. > /trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java, line
177
bq. > <http://review.cloudera.org/r/1262/diff/1/?file=17919#file17919line177>
bq. >
bq. > But on serialization, we use the address hostname not the thing we
actually store in hostname/port variables, so after serialized it's different?
bq. >
bq. > Shouldn't we set the hostname/port variables on construction
according to address.getAddress/getPort rather than the passed values, if the
address values are what we want to use?
I'm... not following you. You're saying that we shouldn't store the
InetSocketAddress?
bq. On 2010-11-30 12:27:06, Jonathan Gray wrote:
bq. > /trunk/src/main/java/org/apache/hadoop/hbase/HServerInfo.java, line 116
bq. > <http://review.cloudera.org/r/1262/diff/1/?file=17920#file17920line116>
bq. >
bq. > I guess we never actually use the String host / int port? Why do we
store them in HServerAddress then?
Here I'm just making sure that after updating the address we also update the
hostname, since it could have changed.
- Jean-Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1262/#review2012
-----------------------------------------------------------
> Master passes IP and not hostname back to region server
> -------------------------------------------------------
>
> Key: HBASE-3286
> URL: https://issues.apache.org/jira/browse/HBASE-3286
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> Starting my little test cluster on the latest from 0.90, I see:
> {noformat}
> 2010-11-29 23:21:34,131 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024
> region(s) across 9 server(s), retainAssignment=true
> 2010-11-29 23:21:34,134 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 22 region(s)
> to sv2borg181,61020,1291072886282
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 24 region(s)
> to sv2borg182,61020,1291072885473
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 37 region(s)
> to sv2borg183,61020,1291072885646
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 25 region(s)
> to sv2borg184,61020,1291072886734
> 2010-11-29 23:21:34,135 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 26 region(s)
> to sv2borg185,61020,1291072886606
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 70 region(s)
> to sv2borg186,61020,1291072885486
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 30 region(s)
> to sv2borg187,61020,1291072886355
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 89 region(s)
> to sv2borg188,61020,1291072885926
> 2010-11-29 23:21:34,136 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 701
> region(s) to sv2borg189,61020,1291072886739
> {noformat}
> After another restart:
> {noformat}
> 2010-11-30 00:03:38,100 INFO
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024
> region(s) across 9 server(s), retainAssignment=true
> 2010-11-30 00:03:38,103 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s)
> to sv2borg181,61020,1291075409984
> 2010-11-30 00:03:38,103 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 82 region(s)
> to sv2borg182,61020,1291075409956
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 61 region(s)
> to sv2borg183,61020,1291075409952
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 122
> region(s) to sv2borg184,61020,1291075409957
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 59 region(s)
> to sv2borg185,61020,1291075409955
> 2010-11-30 00:03:38,104 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s)
> to sv2borg186,61020,1291075409963
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 52 region(s)
> to sv2borg187,61020,1291075411049
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 254
> region(s) to sv2borg188,61020,1291075410360
> 2010-11-30 00:03:38,105 DEBUG
> org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 252
> region(s) to sv2borg189,61020,1291075409959
> {noformat}
> I also saw one time where everything was assigned to 189.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
