[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967012#action_12967012
 ] 

Jonathan Gray commented on HBASE-3305:
--------------------------------------

Ted, you want to put this patch up on review board?  Looks pretty close to 
being done but a few small comments.  You can reuse that numServers variable in 
the LoadBalancer method rather than calling .size() every time.  Get rid of the 
"there are x servers online" debug message.

Is there a unit test for the round-robin method?  Want to write on?  It's a 
simple algorithm but always good to have something to detect regressions.

Also, looks like you have tabs in the diff.  HBase style is 2 spaces and no 
tabs.

> Allow round-robin distribution for table created with multiple regions
> ----------------------------------------------------------------------
>
>                 Key: HBASE-3305
>                 URL: https://issues.apache.org/jira/browse/HBASE-3305
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.20.6
>            Reporter: Ted Yu
>         Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to