[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968608#action_12968608
 ] 

HBase Review Board commented on HBASE-3305:
-------------------------------------------

Message from: "Ted Yu" <ted...@yahoo.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2038
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6438>

    A new patch will be uploaded that reverts such changes.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6439>

    I think you're implying rewriting
    AssignmentManager.assignAllUserRegions().
    
    How about creating this method:
    assignAllUserRegions(List<HRegionInfo> regions).
    
    finishInitialization() would pass null to the above method to indicate that 
all user regions should be assigned.
    createTable() would pass the list of regions for the new table.
    
    This way, BulkStartupAssigner doesn't appear in HMaster.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6440>

    Yes. I prefer space between if and left parenthesis.
    
    I will revert anyway.


- Ted





> Allow round-robin distribution for table created with multiple regions
> ----------------------------------------------------------------------
>
>                 Key: HBASE-3305
>                 URL: https://issues.apache.org/jira/browse/HBASE-3305
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.20.6
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to