[
https://issues.apache.org/jira/browse/HBASE-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704866#comment-13704866
]
Sergey Shelukhin commented on HBASE-8918:
-----------------------------------------
The patch removes static final from a bunch of constants. I think it's a bad
idea...
{code}
- public static final boolean SPLIT_SKIP_ERRORS_DEFAULT = false;
+ String SPLITTING_EXT = "-splitting";
+ boolean SPLIT_SKIP_ERRORS_DEFAULT = false;{code}
Many more like these.
> Removes redundant identifiers from interfaces
> ---------------------------------------------
>
> Key: HBASE-8918
> URL: https://issues.apache.org/jira/browse/HBASE-8918
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Fix For: 0.98.0, 0.95.2
>
> Attachments: HBASE-8918.1.patch
>
>
> A lot of interfaces in HBase's source have things like "public" or "abstract"
> modifiers which make no sense. They add to visual clutter, generate warnings
> in lots of IDEs and serve no purpose.
> This is a patch that just removes them all. I understand that it's touching a
> lot of files etc. Your call if you want this kind of patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
