[
https://issues.apache.org/jira/browse/HBASE-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705193#comment-13705193
]
Lars Francke commented on HBASE-8918:
-------------------------------------
Sergey I'm sorry but I'm afraid I don't understand your concern.
I just looked at most of my changes again and they all seem to be interfaces.
http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.3
{quote}
Every field declaration in the body of an interface is implicitly public,
static, and final. It is permitted to redundantly specify any or all of these
modifiers for such fields.
{quote}
http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4
{quote}
It is permitted, but discouraged as a matter of style, to redundantly specify
the public and/or abstract modifier for a method declared in an interface.
{quote}
This patch is intended only to reduce clutter and remove unneeded stuff. I do
not intend any change of scope for any field or method.
Could you elaborate on your comments:
{quote}removing public from interfaces used by coprocessors (e.g.
requestCompaction methods) can also have undesirable effects.{quote}
I don't see how?
{quote}Well, they are classes, actually, so it becomes package private. I was
thinking of InterfaceVisibility attribute...{quote}
> Removes redundant identifiers from interfaces
> ---------------------------------------------
>
> Key: HBASE-8918
> URL: https://issues.apache.org/jira/browse/HBASE-8918
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Fix For: 0.98.0, 0.95.2
>
> Attachments: HBASE-8918.1.patch
>
>
> A lot of interfaces in HBase's source have things like "public" or "abstract"
> modifiers which make no sense. They add to visual clutter, generate warnings
> in lots of IDEs and serve no purpose.
> This is a patch that just removes them all. I understand that it's touching a
> lot of files etc. Your call if you want this kind of patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
