[ https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709371#comment-13709371 ]
Chao Shi commented on HBASE-8884: --------------------------------- bq. this is kind of a big patch... mind putting it up on RB? It would be good to get some other eyes on it (maybe Andrew Purtell?). Good stuff so far from my first pass though Done. Please have a look at https://reviews.apache.org/r/12572/. > Pluggable RpcScheduler > ---------------------- > > Key: HBASE-8884 > URL: https://issues.apache.org/jira/browse/HBASE-8884 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Reporter: Chao Shi > Assignee: Chao Shi > Attachments: hbase-8884.patch, hbase-8884-v2.patch, > hbase-8884-v3.patch, hbase-8884-v4.patch, hbase-8884-v5.patch, > hbase-8884-v6.patch, hbase-8884-v7.patch > > > Today, the RPC scheduling mechanism is pretty simple: it execute requests in > isolated thread-pools based on their priority. In the current implementation, > all normal get/put requests are using the same pool. We'd like to add some > per-user or per-region level isolation, so that a misbehaved user/region will > not saturate the thread-pool and cause DoS to others easily. The idea is > similar to FairScheduler in MR. The current scheduling code is not standalone > and is mixed with others (Connection#processRequest). The issue is the first > step to extract it to an interface, so that people are free to write and test > their own implementations. > This patch doesn't make it completely pluggable yet, as some parameters are > pass from constructor. This is because HMaster and HRegionServer both use > RpcServer and they have different thread-pool size config. Let me know if you > have a solution to this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira