[ https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710907#comment-13710907 ]
Hadoop QA commented on HBASE-8884: ---------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592739/hbase-8884-v8.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6374//console This message is automatically generated. > Pluggable RpcScheduler > ---------------------- > > Key: HBASE-8884 > URL: https://issues.apache.org/jira/browse/HBASE-8884 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Reporter: Chao Shi > Assignee: Chao Shi > Attachments: hbase-8884.patch, hbase-8884-v2.patch, > hbase-8884-v3.patch, hbase-8884-v4.patch, hbase-8884-v5.patch, > hbase-8884-v6.patch, hbase-8884-v7.patch, hbase-8884-v8.patch > > > Today, the RPC scheduling mechanism is pretty simple: it execute requests in > isolated thread-pools based on their priority. In the current implementation, > all normal get/put requests are using the same pool. We'd like to add some > per-user or per-region level isolation, so that a misbehaved user/region will > not saturate the thread-pool and cause DoS to others easily. The idea is > similar to FairScheduler in MR. The current scheduling code is not standalone > and is mixed with others (Connection#processRequest). The issue is the first > step to extract it to an interface, so that people are free to write and test > their own implementations. > This patch doesn't make it completely pluggable yet, as some parameters are > pass from constructor. This is because HMaster and HRegionServer both use > RpcServer and they have different thread-pool size config. Let me know if you > have a solution to this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira