[
https://issues.apache.org/jira/browse/HBASE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739762#comment-13739762
]
stack commented on HBASE-8348:
------------------------------
This is great.
I wonder if we should call the step 'upgrade' rather than 'migrate' (We used to
call it 'migrate' but hadoop talks abot 'upgrading').
So what is the below doing?
+ elif [ "$COMMAND" = "migrate" ] ; then
+ "$bin"/hbase-cleanup.sh --config ${HBASE_CONF_DIR} --migrate
+ exitCode=$?
+ if [ "$exitCode" = "0" ]; then
+ "$bin"/hbase org.apache.hadoop.hbase.util.HFileV1Detector $@
+ fi
+ exit $?
So we clean up zk and hdfs first and then run the hfilev1 detector? Should the
detector run first?
Should we rename the hbase-cleanup.sh script to be called migrate.sh or
upgrade.sh now it does more than cleaning?
THis script looks excellent. Nice work [~rajesh23] Let me delete the one I
started over in HBASE-9134.
[[email protected]] What you think?
> Polish the migration to 0.96
> ----------------------------
>
> Key: HBASE-8348
> URL: https://issues.apache.org/jira/browse/HBASE-8348
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.0
> Reporter: Jean-Daniel Cryans
> Assignee: rajeshbabu
> Priority: Critical
> Fix For: 0.95.2
>
> Attachments: HBASE-8348_trunk.patch, HBASE-8348_trunk_v2.patch,
> HBASE-8348_trunk_v3.patch
>
>
> Currently, migration works but there's still a couple of rough edges:
> - HBASE-8045 finished the .META. migration but didn't remove ROOT, so it's
> still on the filesystem.
> - Data in ZK needs to be removed manually. Either we fix up the data in ZK
> or we delete it ourselves.
> - TestMetaMigrationRemovingHTD has a testMetaUpdatedFlagInROOT method, but
> ROOT is gone now.
> Elliott was also mentioning that we could have "hbase migrate" do the HFileV1
> checks, clear ZK, remove ROOT, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
