[ 
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750997#comment-13750997
 ] 

Devaraj Das commented on HBASE-9116:
------------------------------------

bq. Why not just call initialize() at the end of the constructor body?
The reason being I wanted to keep the construction of the object cheap. The 
initialization does some IO since it scans the meta, and I wanted to keep this 
out of the basic constructor...

bq. Is it worth RegionPlacementMaintainer extending AbstractHBaseTool?
IMHO this is not going to add that much value. Do you mind if I look at this in 
a follow up.

bq. Is this necessary – can you instead separate out "case 2" as a second test?
  -@Test(timeout = 180000)
  +@Test(timeout = 1800000)

Fixed the timeout (that was a good catch). The reason the test is clubbed into 
one is that the test tries out the various favorednode utilities with a single 
table that it creates in the beginning.
                
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
>                 Key: HBASE-9116
>                 URL: https://issues.apache.org/jira/browse/HBASE-9116
>             Project: HBase
>          Issue Type: Improvement
>          Components: Region Assignment
>    Affects Versions: 0.95.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 
> 9116-3.txt, 9116-4.txt, 9116-5.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for 
> regions, and also fix the mappings if needed. Such a tool exists in the 
> 0.89-fb branch. Will port it over to trunk/0.95.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to