[ https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751515#comment-13751515 ]
Devaraj Das commented on HBASE-9116: ------------------------------------ Thanks, Nick. bq. I regard tweaking test timeouts as a kind of code smell. I had increased the timeout so I could debug various things from within eclipse without the test timing out on me. The timeout annotation in the new patch is 3 minutes (which is what it was set to earlier) but I could actually remove that timeout annotation altogether on commit. The test runs in less than 2 minutes consistently.. bq. AssignmentVerificationReport has separate logic blocks for floating point if (A > B) else if (A == B) – I wonder if this will be a future source of bugs. I inspected that part some. The logic for reporting the max/min dispersion is built around the check for equality. This is used only for reporting purposes and we can tune this later if needed. > Add a view/edit tool for favored node mappings for regions > ---------------------------------------------------------- > > Key: HBASE-9116 > URL: https://issues.apache.org/jira/browse/HBASE-9116 > Project: HBase > Issue Type: Improvement > Components: Region Assignment > Affects Versions: 0.95.0 > Reporter: Devaraj Das > Assignee: Devaraj Das > Fix For: 0.96.0 > > Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, > 9116-3.txt, 9116-4.txt, 9116-5.txt, 9116-6.txt > > > Add a tool that one can run offline to view the favored node mappings for > regions, and also fix the mappings if needed. Such a tool exists in the > 0.89-fb branch. Will port it over to trunk/0.95. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira