[
https://issues.apache.org/jira/browse/HBASE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759433#comment-13759433
]
Jeffrey Zhong commented on HBASE-9411:
--------------------------------------
Looks good to me! +1. Thanks.
> Increment / decrement of rpcCount in RpcServer#Connection is not protected by
> synchronization
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-9411
> URL: https://issues.apache.org/jira/browse/HBASE-9411
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 9411-v1.txt
>
>
> Here is related code:
> {code}
> /* Decrement the outstanding RPC count */
> protected void decRpcCount() {
> rpcCount--;
> }
> /* Increment the outstanding RPC count */
> protected void incRpcCount() {
> rpcCount++;
> }
> {code}
> Even though rpcCount is volatile, in non atomic operations (increment /
> decrement) different threads may get unexpected result.
> See
> http://stackoverflow.com/questions/7805192/is-a-volatile-int-in-java-thread-safe
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
