[ 
https://issues.apache.org/jira/browse/HBASE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759696#comment-13759696
 ] 

Hudson commented on HBASE-9411:
-------------------------------

FAILURE: Integrated in HBase-TRUNK #4472 (See 
[https://builds.apache.org/job/HBase-TRUNK/4472/])
HBASE-9411 Increment / decrement of rpcCount in RpcServer#Connection is not 
protected by synchronization (tedyu: rev 1520438)
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java

                
> Increment / decrement of rpcCount in RpcServer#Connection is not protected by 
> synchronization
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9411
>                 URL: https://issues.apache.org/jira/browse/HBASE-9411
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.98.0
>
>         Attachments: 9411-v1.txt
>
>
> Here is related code:
> {code}
>     /* Decrement the outstanding RPC count */
>     protected void decRpcCount() {
>       rpcCount--;
>     }
>     /* Increment the outstanding RPC count */
>     protected void incRpcCount() {
>       rpcCount++;
>     }
> {code}
> Even though rpcCount is volatile, in non atomic operations (increment / 
> decrement) different threads may get unexpected result.
> See 
> http://stackoverflow.com/questions/7805192/is-a-volatile-int-in-java-thread-safe

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to