[ https://issues.apache.org/jira/browse/HBASE-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782015#comment-13782015 ]
Hadoop QA commented on HBASE-9612: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605927/9612v5.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7420//console This message is automatically generated. > Ability to batch edits destined to different regions > ---------------------------------------------------- > > Key: HBASE-9612 > URL: https://issues.apache.org/jira/browse/HBASE-9612 > Project: HBase > Issue Type: Bug > Affects Versions: 0.95.0, 0.95.1, 0.95.2, 0.96.0 > Reporter: Benoit Sigoure > Assignee: stack > Priority: Critical > Fix For: 0.98.0, 0.96.0 > > Attachments: 9612v2.txt, 9612v3.txt, 9612v4.txt, 9612v5.txt, > 9612.wip.txt > > > The old (pre-PB) "multi" and "multiPut" RPCs allowed one to batch edits > destined to different regions. Seems like we've lost this ability after the > switch to protobufs. > The {{MultiRequest}} only contains one {{RegionSpecifier}}, and a list of > {{MultiAction}}. The {{MultiAction}} message is contains either a single > {{MutationProto}} or a {{Get}} (but not both – so its name is misleading as > there is nothing "multi" about it). Also it seems redundant with > {{MultiGetRequest}}, I'm not sure what's the point of supporting {{Get}} in > {{MultiAction}}. > I propose that we change {{MultiRequest}} to be a just a list of > {{MultiAction}}, and {{MultiAction}} will contain the {{RegionSpecifier}}, > the {{bool atomic}} and a list of {{MutationProto}}. This would be a > non-backward compatible protobuf change. > If we want we can support mixing edits and reads, in which case we'd also add > a list of {{Get}} in {{MultiAction}}, and we'd have support having both that > list and the list of {{MutationProto}} set at the same time. But this is a > bonus and can be done later (in a backward compatible manner, hence no need > to rush on this one). -- This message was sent by Atlassian JIRA (v6.1#6144)