[
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053920#comment-13053920
]
jirapos...@reviews.apache.org commented on HBASE-3939:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/
-----------------------------------------------------------
Review request for hbase and Todd Lipcon.
Summary
-------
A few fixes from Hadoop IPC that we should probably cross-port into our copy:
* HADOOP-7227: remove the protocol version check at call time
* HADOOP-7146: fix a socket leak in server
* HADOOP-7121: fix behavior when response serialization throws an exception
* HADOOP-7346: send back nicer error response when client is using an out
of date IPC version
This addresses bug HBASE-3939.
https://issues.apache.org/jira/browse/HBASE-3939
Diffs
-----
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
1137262
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java
1137262
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
1137262
/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 1137280
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362
/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
1134732
/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732
/src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1134732
/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1134732
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
1137280
Diff: https://reviews.apache.org/r/951/diff
Testing
-------
Test suite passed.
Thanks,
Ted
> Some crossports of Hadoop IPC fixes
> -----------------------------------
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of
> date IPC version
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
