[
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054084#comment-13054084
]
jirapos...@reviews.apache.org commented on HBASE-3939:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review900
-----------------------------------------------------------
What kind of testing did you do with this? We should test old->new RPC to make
sure the error messages come out OK
/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
<https://reviews.apache.org/r/951/#comment1943>
we should check this against old versions of HBase -- the constants I put
in this code are hadoop RPC version numbers, which might not correspond to
hbase IPC version numbers.
ie we should start a trunk server, then try to connect to it from an 0.90
shell, 0.89 shell, 0.20 shell, and make sure it works correctly.
- Todd
On 2011-06-23 20:31:21, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/951/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-23 20:31:21)
bq.
bq.
bq. Review request for hbase and Todd Lipcon.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A few fixes from Hadoop IPC that we should probably cross-port into our
copy:
bq.
bq. * HADOOP-7227: remove the protocol version check at call time
bq. * HADOOP-7146: fix a socket leak in server
bq. * HADOOP-7121: fix behavior when response serialization throws an
exception
bq. * HADOOP-7346: send back nicer error response when client is using an
out of date IPC version
bq.
bq.
bq. This addresses bug HBASE-3939.
bq. https://issues.apache.org/jira/browse/HBASE-3939
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
1137262
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java
1137262
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
1137262
bq. /src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java
1137280
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java
PRE-CREATION
bq. /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
1134732
bq. /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1134732
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
1137280
bq.
bq. Diff: https://reviews.apache.org/r/951/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test suite passed.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> Some crossports of Hadoop IPC fixes
> -----------------------------------
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of
> date IPC version
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
