[ https://issues.apache.org/jira/browse/HBASE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881799#comment-13881799 ]
Hadoop QA commented on HBASE-10416: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625121/HBASE-10416.patch against trunk revision . ATTACHMENT ID: 12625121 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop 1.0 profile. {color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop 1.1 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8504//console This message is automatically generated. > Improvements to the import flow > ------------------------------- > > Key: HBASE-10416 > URL: https://issues.apache.org/jira/browse/HBASE-10416 > Project: HBase > Issue Type: New Feature > Components: mapreduce > Reporter: Vasu Mariyala > Attachments: HBASE-10416.patch > > > Following improvements can be made to the Import logic > a) Make the import extensible (i.e., remove the filter from being a static > member of Import and make it an instance variable of the mapper, make the > mappers or variables of interest protected. ) > b) Make sure that the Import calls filterRowKey method of the filter (Useful > if we want to filter the data of an organization based on the row key or > using filters like PrefixFilter which filter the data in filterRowKey method > rather than the filterKeyValue method). The existing test case in > TestImportExport#testWithFilter works with this assumption but is so far > successful because there is only one row inserted into the table. > c) Provide an option to specify the durability during the import (Specifying > the Durability as SKIP_WAL would improve the performance of restore > considerably.) [~lhofhansl] suggested that this should be a parameter to the > import. > d) Some minor refactoring to avoid building a comma separated string for the > filter args. -- This message was sent by Atlassian JIRA (v6.1.5#6160)