[
https://issues.apache.org/jira/browse/HBASE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884491#comment-13884491
]
Vasu Mariyala commented on HBASE-10416:
---------------------------------------
Sorry for the delay and thanks for the review comments
[~yuzhih...@gmail.com]
1. Felt that constructing a filter object from filter class and filter args
would be utility method and would be useful when extending the import utility
for specific customizations.
2. Fixed the long line & the java doc warnings.
3. Updated the release note description in the jira.
[~ndimiduk]
Saw your other issues related to making things like mapper or reducer
configurable and reuse the code. Would you mind discussing on these issues when
you are free. You can ping me in gmail.
> Improvements to the import flow
> -------------------------------
>
> Key: HBASE-10416
> URL: https://issues.apache.org/jira/browse/HBASE-10416
> Project: HBase
> Issue Type: New Feature
> Components: mapreduce
> Reporter: Vasu Mariyala
> Attachments: HBASE-10416-rev1.patch, HBASE-10416.patch
>
>
> Following improvements can be made to the Import logic
> a) Make the import extensible (i.e., remove the filter from being a static
> member of Import and make it an instance variable of the mapper, make the
> mappers or variables of interest protected. )
> b) Make sure that the Import calls filterRowKey method of the filter (Useful
> if we want to filter the data of an organization based on the row key or
> using filters like PrefixFilter which filter the data in filterRowKey method
> rather than the filterKeyValue method). The existing test case in
> TestImportExport#testWithFilter works with this assumption but is so far
> successful because there is only one row inserted into the table.
> c) Provide an option to specify the durability during the import (Specifying
> the Durability as SKIP_WAL would improve the performance of restore
> considerably.) [~lhofhansl] suggested that this should be a parameter to the
> import.
> d) Some minor refactoring to avoid building a comma separated string for the
> filter args.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
