[
https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882088#comment-13882088
]
stack commented on HBASE-3909:
------------------------------
Patch is great. Lets get it in. There is a hole in that the admin client does
not know how to talk to backup master which we should fix in general but it
should not get in the way of this patch. What you think [~aoxiang]? Apply
this as is and then add configs as we go? Needs a bit of doc. so devs know
this mechanism exists. Would suggest fixing the class comment so it uses
javadoc formatting especially given the documentation on the class is so good.
Rereading the old comments on this issue talking of hoisting configs up into zk
so we can exploit its callback mechanism, this mechanism does none of that and
just has us reload the configs from under the running processors.
One concern I'd have is that we are reloading the configs but the Server
constructors do a bunch of checking and setting on configs. Will these
settings be lost when we reload from raw configs on disk. For example, HRS
constructor calls FSUtils.setupShortCircuitRead(this.conf). Do these settings
persist pas the reload call?
Good stuff.
> Add dynamic config
> ------------------
>
> Key: HBASE-3909
> URL: https://issues.apache.org/jira/browse/HBASE-3909
> Project: HBase
> Issue Type: New Feature
> Reporter: stack
> Assignee: Subbu M Iyer
> Attachments: 3909-102812.patch, 3909-102912.patch, 3909-v1.patch,
> 3909.v1, 3909_090712-2.patch, HBASE-3909-backport-from-fb-for-trunk-2.patch,
> HBASE-3909-backport-from-fb-for-trunk.patch, HBase Cluster Config
> Details.xlsx, patch-v2.patch, testMasterNoCluster.stack
>
>
> I'm sure this issue exists already, at least as part of the discussion around
> making online schema edits possible, but no hard this having its own issue.
> Ted started a conversation on this topic up on dev and Todd suggested we
> lookd at how Hadoop did it over in HADOOP-7001
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
