[
https://issues.apache.org/jira/browse/HBASE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911907#comment-13911907
]
Hadoop QA commented on HBASE-10604:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630980/HBASE-10604-v0-trunk.patch
against trunk revision .
ATTACHMENT ID: 12630980
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8800//console
This message is automatically generated.
> Fix parseArgs javadoc
> ---------------------
>
> Key: HBASE-10604
> URL: https://issues.apache.org/jira/browse/HBASE-10604
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
> Attachments: HBASE-10604-v0-trunk.patch
>
>
> Javadoc for parseArgs is a cut&past of previous method and need to be fixed.
> {code}
> /*
> * Adds a region's meta information from the passed <code>meta</code>
> * region.
> *
> * @param metainfo hbase:meta HRegionInfo to be updated
> * @param region HRegion to add to <code>meta</code>
> *
> * @throws IOException
> */
> private int parseArgs(String[] args) throws IOException {
> GenericOptionsParser parser =
> new GenericOptionsParser(getConf(), args);
> String[] remainingArgs = parser.getRemainingArgs();
> if (remainingArgs.length != 3) {
> usage();
> return -1;
> }
> tableName = TableName.valueOf(remainingArgs[0]);
> region1 = Bytes.toBytesBinary(remainingArgs[1]);
> region2 = Bytes.toBytesBinary(remainingArgs[2]);
> int status = 0;
> if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
> status = -1;
> } else if (Bytes.equals(region1, region2)) {
> LOG.error("Can't merge a region with itself");
> status = -1;
> }
> return status;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
