[ 
https://issues.apache.org/jira/browse/HBASE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912386#comment-13912386
 ] 

Hudson commented on HBASE-10604:
--------------------------------

FAILURE: Integrated in hbase-0.96-hadoop2 #216 (See 
[https://builds.apache.org/job/hbase-0.96-hadoop2/216/])
HBASE-10604 Fix parseArgs javadoc (Jean-Marc Spaggiari) (stack: rev 1571811)
* 
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/Merge.java


> Fix parseArgs javadoc
> ---------------------
>
>                 Key: HBASE-10604
>                 URL: https://issues.apache.org/jira/browse/HBASE-10604
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>             Fix For: 0.96.2, 0.98.1, 0.99.0
>
>         Attachments: HBASE-10604-v0-trunk.patch
>
>
> Javadoc for parseArgs is a cut&past of previous method and need to be fixed.
> {code}
>   /*
>    * Adds a region's meta information from the passed <code>meta</code>
>    * region.
>    *
>    * @param metainfo hbase:meta HRegionInfo to be updated
>    * @param region HRegion to add to <code>meta</code>
>    *
>    * @throws IOException
>    */
>   private int parseArgs(String[] args) throws IOException {
>     GenericOptionsParser parser =
>       new GenericOptionsParser(getConf(), args);
>     String[] remainingArgs = parser.getRemainingArgs();
>     if (remainingArgs.length != 3) {
>       usage();
>       return -1;
>     }
>     tableName = TableName.valueOf(remainingArgs[0]);
>     region1 = Bytes.toBytesBinary(remainingArgs[1]);
>     region2 = Bytes.toBytesBinary(remainingArgs[2]);
>     int status = 0;
>     if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
>       status = -1;
>     } else if (Bytes.equals(region1, region2)) {
>       LOG.error("Can't merge a region with itself");
>       status = -1;
>     }
>     return status;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to