[ 
https://issues.apache.org/jira/browse/HBASE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942686#comment-13942686
 ] 

Hadoop QA commented on HBASE-10569:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12635924/hbase-10569_v2.patch
  against trunk revision .
  ATTACHMENT ID: 12635924

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 183 
new or modified tests.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 8 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                
t.getMessage().contains("org/apache/hadoop/hdfs/protocol/FSConstants$SafeModeAction"))
 {
+      for(HTableDescriptor htd: 
master.listTableDescriptorsByNamespace(request.getNamespaceName())) {
+      Threads.setDaemonThreadRunning(this.healthCheckChore.getThread(), 
getName() + ".healthChecker",
+      Threads.setDaemonThreadRunning(this.nonceManagerChore.getThread(), 
getName() + ".nonceCleaner",
+      final RegionActionResult.Builder builder, List<CellScannable> 
cellsToReturn, long nonceGroup) {
+      boolean closed = regionServer.closeRegion(encodedRegionName, false, zk, 
versionOfClosingNode, sn);
+            Boolean closing = 
regionServer.regionsInTransitionInRS.get(region.getEncodedNameAsBytes());
+          regionServer.nonceManager.reportOperationFromWal(nonceGroup, nonce, 
entry.getKey().getWriteTime());
+    MasterCoprocessorHost cpHost = 
util.getMiniHBaseCluster().getMaster().getMasterCoprocessorHost();
+        for (HRegionInfo r : 
ProtobufUtil.getOnlineRegions(t.getRegionServer().getRSRpcServices())) {

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:368)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9056//console

This message is automatically generated.

> Co-locate meta and master
> -------------------------
>
>                 Key: HBASE-10569
>                 URL: https://issues.apache.org/jira/browse/HBASE-10569
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, Region Assignment
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-10569_v1.patch, hbase-10569_v2.patch
>
>
> I was thinking simplifying/improving the region assignments. The first step 
> is to co-locate the meta and the master as many people agreed on HBASE-5487.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to