[
https://issues.apache.org/jira/browse/HBASE-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966193#comment-13966193
]
Matt Corgan commented on HBASE-10801:
-------------------------------------
{quote}I am not sure if we can change the logic of how the hfs.next() is
getting called. Generally the next KV is also fetched and the comparison is
done to load the next store file if the key is already seeked key is already
bigger. Changing that would be a bigger task too.{quote}More fun to be had =).
It's a similar problem to java's built-in Iterable interface requiring a
hasNext() method which means you have to "detect" the next element before
consuming the current one. In a true streaming environment that can be
inefficient like we're seeing here. The point of the CellScanner interface was
to remove hasNext() in favor of checking if(advance()==null), where you don't
know about the next cell until there isn't one.
After a quick look, it seems this strategy is ok but hopefully just temporary.
I'm worried there's some added complexity in a core code path without explicit
tests, but it seems like a good stepping stone. I'm not sure if it's better to
do the whole bigger change at the same time. I don't mean that to be a
recommendation either way - just not sure.
> Ensure DBE interfaces can work with Cell
> ----------------------------------------
>
> Key: HBASE-10801
> URL: https://issues.apache.org/jira/browse/HBASE-10801
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10801.patch, HBASE-10801_1.patch,
> HBASE-10801_2.patch, HBASE-10801_3.patch
>
>
> Some changes to the interfaces may be needed for DBEs or may be the way it
> works currently may be need to be modified inorder to make DBEs work with
> Cells. Suggestions and ideas welcome.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
