[ 
https://issues.apache.org/jira/browse/HBASE-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973172#comment-13973172
 ] 

Enis Soztutar commented on HBASE-10934:
---------------------------------------

This patch looks good. There are a couple of changes that I want to make in the 
Admin interface before 1.0: 
 - Remove all methods that accept table name as byte[] and string. We should 
only have the TableName arguments. No need to bloat the interfaces. 
 - remove the methods that accept tableNameOrRegionName. This is unacceptable. 
We should have xxxRegion(), xxxTable() methods instead. 
 - rethink some of the methods whether they should be exposed (like 
getMasterCoprocessors() as above) 

However, I think we can commit this patch, and make the changes above in a 
follow up patch, or as a part of HBASE-10602. I'll commit this shortly. 


> Provide HBaseAdminInterface to abstract HBaseAdmin
> --------------------------------------------------
>
>                 Key: HBASE-10934
>                 URL: https://issues.apache.org/jira/browse/HBASE-10934
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Carter
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.99.0
>
>         Attachments: HBASE_10934.patch, HBASE_10934_2.patch
>
>
> As HBaseAdmin is essentially the administrative API, it would seem to follow 
> Java best practices to provide an interface to access it instead of requiring 
> applications to use the raw object.
> I am proposing (and would be happy to develop):
>  * A new interface, HBaseAdminInterface, that captures the signatures of the 
> API (HBaseAdmin will implement this interface)
>  * A new method, HConnection.getHBaseAdmin(), that returns an instance of the 
> interface



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to