[ 
https://issues.apache.org/jira/browse/HBASE-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044405#comment-14044405
 ] 

Matteo Bertozzi commented on HBASE-11148:
-----------------------------------------

quick look at the code and looks ok, its kind of copy paste of what was done 
for the Flush.

my main concern again is about the use of the Procedure for this kind of use.
If you have a failure on a RS, the client will receive an error but half of the 
logs may be rolled.

> Provide a distributed procedure to globally roll logs
> -----------------------------------------------------
>
>                 Key: HBASE-11148
>                 URL: https://issues.apache.org/jira/browse/HBASE-11148
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11148-trunk-v1.patch, HBASE-11148-trunk-v2.patch
>
>
> Propose a distributed procedure here to globally roll logs.
> Currently HBaseAdmin and HBase shell provides a way to roll the WAL on a 
> single RS.
> Some use cases may require that all the RS roll the logs at the same time and 
> in a coordinated way. Also there may be requirement that some tasks be done 
> together with the roll log on each region server.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to