[ 
https://issues.apache.org/jira/browse/HBASE-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044814#comment-14044814
 ] 

Ted Yu commented on HBASE-11148:
--------------------------------

lgtm

There're some typo's, e.g. "procdure":
{code}
+          new ForeignException("Interrupted while waiting for roll log 
procdure to finish", e);
{code}
Add annotation for audience:
{code}
+public class RollLogSubprocedure extends Subprocedure {
{code}
Is the following method needed in RollLogSubprocedure ?
{code}
+  public void releaseBarrier() {
+    // NO OP
+  }
{code}


> Provide a distributed procedure to globally roll logs
> -----------------------------------------------------
>
>                 Key: HBASE-11148
>                 URL: https://issues.apache.org/jira/browse/HBASE-11148
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11148-trunk-v1.patch, HBASE-11148-trunk-v2.patch
>
>
> Propose a distributed procedure here to globally roll logs.
> Currently HBaseAdmin and HBase shell provides a way to roll the WAL on a 
> single RS.
> Some use cases may require that all the RS roll the logs at the same time and 
> in a coordinated way. Also there may be requirement that some tasks be done 
> together with the roll log on each region server.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to