[
https://issues.apache.org/jira/browse/HBASE-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060345#comment-14060345
]
stack commented on HBASE-10930:
-------------------------------
Looks great.
We giving up functionality here?
public Cell getNextCellHint(Cell currentKV) throws IOException {
- // Old filters based off of this class will override KeyValue
getNextKeyHint(KeyValue).
- // Thus to maintain compatibility we need to call the old version.
- return getNextKeyHint(KeyValueUtil.ensureKeyValue(currentKV));
+ return null;
Can we change name of internal members from transformKV to tranformCell?
- return transform(KeyValueUtil.ensureKeyValue(v));
+ if (!CellComparator.equals(v, referenceKV)) {
+ throw new IllegalStateException("Reference Cell: " + this.referenceKV +
" does not match: "
+ + v);
+ }
+ return this.transformedKV;
Ditto for referenceKV?
Change this from kv to c?
public ReturnCode filterKeyValue(Cell kv) {
Ditto here:
public Cell getNextCellHint(Cell currentKV) {
I suggest this because you've done all this nice clean up... it is a shame to
leave these little references to kv around when simple to change.
On other hand [~ram_krish], the above comments are nits. +1 on commit. Change
some of the above if want but if you don't I'm good w/ the patch as is. Can do
the nits in subsequent work. Good stuff.
> Change Filters and GetClosestRowBeforeTracker to work with Cells
> ----------------------------------------------------------------
>
> Key: HBASE-10930
> URL: https://issues.apache.org/jira/browse/HBASE-10930
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10930.patch, HBASE-10930_1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
