[
https://issues.apache.org/jira/browse/HBASE-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060446#comment-14060446
]
ramkrishna.s.vasudevan commented on HBASE-10930:
------------------------------------------------
Ok. I can update the patch changing kv to cell. I think its better to change
here.
{code}
public Cell getNextCellHint(Cell currentKV) throws IOException {
// Old filters based off of this class will override KeyValue
getNextKeyHint(KeyValue).
// Thus to maintain compatibility we need to call the old version.
return getNextKeyHint(KeyValueUtil.ensureKeyValue(currentKV));
+ return null;
{code}
bq.We giving up functionality here?
Actually in other places where the getNextKeyHint is called it is not changed
(still it uses KeyvalueUtil.ensureKeyValue()). The reason for changing in
FilterBase was that it is the default base implementation for any filters. In
the existing code
{code}
/**
* This method is deprecated and you should override Cell
getNextKeyHint(Cell) instead.
*/
@Override
@Deprecated
public KeyValue getNextKeyHint(KeyValue currentKV) throws IOException {
return null;
}
/**
* Filters that are not sure which key must be next seeked to, can inherit
* this implementation that, by default, returns a null Cell.
*
* @inheritDoc
*/
public Cell getNextCellHint(Cell currentKV) throws IOException {
// Old filters based off of this class will override KeyValue
getNextKeyHint(KeyValue).
// Thus to maintain compatibility we need to call the old version.
return getNextKeyHint(KeyValueUtil.ensureKeyValue(currentKV));
}
{code}
So we were calling getNextKeyHint but returning null eventually. So any filter
implementing FilterBase if they had needed some real behaviour with
getNextKeyHint() would have implemented in its filter class. So the change in
FilterBase getNextCellHint is fine ? Am i missing something here?
> Change Filters and GetClosestRowBeforeTracker to work with Cells
> ----------------------------------------------------------------
>
> Key: HBASE-10930
> URL: https://issues.apache.org/jira/browse/HBASE-10930
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10930.patch, HBASE-10930_1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
