[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248729#comment-14248729
 ] 

Varun Saxena commented on HBASE-12645:
--------------------------------------

[~stack], if the flag is false, {{getDefaultRootDirPath()}} calls below 
function. As you can see, if {{dataTestDirOnTestFS}} is null, directory path is 
created/fetched again.
If not, previous value is retrieved. When the flag is true,  we create a new 
path irrespective of whether dataTestDirOnTestFS is null or not.
{code}
public Path getDataTestDirOnTestFS() throws IOException {
    if (dataTestDirOnTestFS == null) {
      setupDataTestDirOnTestFS();
    }

    return dataTestDirOnTestFS;
  }
{code}

> HBaseTestingUtility is using ${$HOME} for rootDir
> -------------------------------------------------
>
>                 Key: HBASE-12645
>                 URL: https://issues.apache.org/jira/browse/HBASE-12645
>             Project: HBase
>          Issue Type: Test
>          Components: test
>    Affects Versions: 1.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Varun Saxena
>            Priority: Critical
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
>         at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
>         at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
>         at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
>         at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to