[ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279198#comment-14279198 ]
Elliott Clark commented on HBASE-12684: --------------------------------------- +1 to the patch. There will likely be some clean up to do, however it's a really nice patch already. ( Lets get this into branch-1 but off by default as [~stack] suggested ) Then we can start IT testing it. Thanks > Add new AsyncRpcClient > ---------------------- > > Key: HBASE-12684 > URL: https://issues.apache.org/jira/browse/HBASE-12684 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Jurriaan Mous > Assignee: Jurriaan Mous > Attachments: HBASE-12684-DEBUG2.patch, HBASE-12684-DEBUG3.patch, > HBASE-12684-v1.patch, HBASE-12684-v10.patch, HBASE-12684-v11.patch, > HBASE-12684-v12.patch, HBASE-12684-v13.patch, HBASE-12684-v14.patch, > HBASE-12684-v15.patch, HBASE-12684-v16.patch, HBASE-12684-v17.patch, > HBASE-12684-v17.patch, HBASE-12684-v18.patch, HBASE-12684-v19.1.patch, > HBASE-12684-v19.patch, HBASE-12684-v19.patch, HBASE-12684-v2.patch, > HBASE-12684-v20-heapBuffer.patch, HBASE-12684-v20.patch, > HBASE-12684-v21-heapBuffer.1.patch, HBASE-12684-v21-heapBuffer.patch, > HBASE-12684-v21.patch, HBASE-12684-v22.patch, HBASE-12684-v23-epoll.patch, > HBASE-12684-v24.patch, HBASE-12684-v24.patch, HBASE-12684-v24.patch, > HBASE-12684-v24.patch, HBASE-12684-v24.patch, HBASE-12684-v25.patch, > HBASE-12684-v26.patch, HBASE-12684-v27.patch, HBASE-12684-v27.patch, > HBASE-12684-v28.patch, HBASE-12684-v29.patch, HBASE-12684-v3.patch, > HBASE-12684-v30.patch, HBASE-12684-v4.patch, HBASE-12684-v5.patch, > HBASE-12684-v6.patch, HBASE-12684-v7.patch, HBASE-12684-v8.patch, > HBASE-12684-v9.patch, HBASE-12684.patch, Screen Shot 2015-01-11 at 11.55.32 > PM.png, myrecording.jfr, q.png, requests.png > > > With the changes in HBASE-12597 it is possible to add new RpcClients. This > issue is about adding a new Async RpcClient which would enable HBase to do > non blocking protobuf service communication. > Besides delivering a new AsyncRpcClient I would also like to ask the question > what it would take to replace the current RpcClient? This would enable to > simplify async code in some next issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)