[ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280347#comment-14280347 ]
Hadoop QA commented on HBASE-12684: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692752/HBASE-12684-v31.patch against master branch at commit 621b33f2f9677bd30c78de0ada757b4349eb017b. ATTACHMENT ID: 12692752 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.sling.commons.testing.integration.TestInfoPassingClient.executeMethod(TestInfoPassingClient.java:43) at org.apache.sling.commons.testing.integration.SlingIntegrationTestClient.delete(SlingIntegrationTestClient.java:59) at org.apache.sling.launchpad.webapp.integrationtest.indexing.FullTextIndexingTest.tearDown(FullTextIndexingTest.java:95) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12487//console This message is automatically generated. > Add new AsyncRpcClient > ---------------------- > > Key: HBASE-12684 > URL: https://issues.apache.org/jira/browse/HBASE-12684 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Jurriaan Mous > Assignee: Jurriaan Mous > Attachments: HBASE-12684-DEBUG2.patch, HBASE-12684-DEBUG3.patch, > HBASE-12684-v1.patch, HBASE-12684-v10.patch, HBASE-12684-v11.patch, > HBASE-12684-v12.patch, HBASE-12684-v13.patch, HBASE-12684-v14.patch, > HBASE-12684-v15.patch, HBASE-12684-v16.patch, HBASE-12684-v17.patch, > HBASE-12684-v17.patch, HBASE-12684-v18.patch, HBASE-12684-v19.1.patch, > HBASE-12684-v19.patch, HBASE-12684-v19.patch, HBASE-12684-v2.patch, > HBASE-12684-v20-heapBuffer.patch, HBASE-12684-v20.patch, > HBASE-12684-v21-heapBuffer.1.patch, HBASE-12684-v21-heapBuffer.patch, > HBASE-12684-v21.patch, HBASE-12684-v22.patch, HBASE-12684-v23-epoll.patch, > HBASE-12684-v24.patch, HBASE-12684-v24.patch, HBASE-12684-v24.patch, > HBASE-12684-v24.patch, HBASE-12684-v24.patch, HBASE-12684-v25.patch, > HBASE-12684-v26.patch, HBASE-12684-v27.patch, HBASE-12684-v27.patch, > HBASE-12684-v28.patch, HBASE-12684-v29.patch, HBASE-12684-v3.patch, > HBASE-12684-v30.patch, HBASE-12684-v30.patch, HBASE-12684-v30.patch, > HBASE-12684-v31.patch, HBASE-12684-v4.patch, HBASE-12684-v5.patch, > HBASE-12684-v6.patch, HBASE-12684-v7.patch, HBASE-12684-v8.patch, > HBASE-12684-v9.patch, HBASE-12684.patch, Screen Shot 2015-01-11 at 11.55.32 > PM.png, myrecording.jfr, q.png, requests.png > > > With the changes in HBASE-12597 it is possible to add new RpcClients. This > issue is about adding a new Async RpcClient which would enable HBase to do > non blocking protobuf service communication. > Besides delivering a new AsyncRpcClient I would also like to ask the question > what it would take to replace the current RpcClient? This would enable to > simplify async code in some next issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)