[ 
https://issues.apache.org/jira/browse/HBASE-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366376#comment-14366376
 ] 

Josh Elser commented on HBASE-13262:
------------------------------------

I'm a little confused given what you suggested:

bq. The problem here is that there is an implied relationship between the size 
calculation on the server and the size calculation on the client: The two sizes 
MUST be equal. If the server reaches the size limit, it is implied that the 
client should also reach the size limit.... This is where the issue occurs.

Are you implying that this is specifically the problem? I'm not seeing where 
these sizes are used for anything more than metrics tracking (on client and 
server, {{ScannerCallable#updateResultsMetrics(Result[])}} and 
{{MetricsRegion#updateScanNext(long)}} (called via {{RSRpcServices#scan(..)}}, 
respectively).

To me, the larger issue seems to be that only a {{Result[]}} is returned from 
{{ScannerCallable}} back to {{ClientScanner}} as 
{{ScanResponse.getMoreResults()}} is hidden in the callable implementation. 
Thus, the scanner impl needs to some how reason about more results on being on 
the server even when we don't have any partial results cached.

That being said, I think I need to look at this with some fresh eyes :). Please 
correct me if I missed something.

> ResultScanner doesn't return all rows in Scan
> ---------------------------------------------
>
>                 Key: HBASE-13262
>                 URL: https://issues.apache.org/jira/browse/HBASE-13262
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0, 1.1.0
>         Environment: Single node, pseduo-distributed 1.1.0-SNAPSHOT
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: testrun_0.98.txt, testrun_branch1.0.txt
>
>
> Tried to write a simple Java client again 1.1.0-SNAPSHOT.
> * Write 1M rows, each row with 1 family, and 10 qualifiers (values [0-9]), 
> for a total of 10M cells written
> * Read back the data from the table, ensure I saw 10M cells
> Running it against {{04ac1891}} (and earlier) yesterday, I would get ~20% of 
> the actual rows. Running against 1.0.0, returns all 10M records as expected.
> [Code I was 
> running|https://github.com/joshelser/hbase-hwhat/blob/master/src/main/java/hbase/HBaseTest.java]
>  for the curious.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to