[ https://issues.apache.org/jira/browse/HBASE-13517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504777#comment-14504777 ]
Hadoop QA commented on HBASE-13517: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726823/HBASE-13517-v2.patch against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472. ATTACHMENT ID: 12726823 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:red}-1 javac{color}. The applied patch generated 55 javac compiler warnings (more than the master's current 5 warnings). {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <!-- Hadoop and HBase depend on an old Guava, don't expose it to dependents --> + <shadedPattern>org.apache.hadoop.hbase.io.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.jboss.netty</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.mortbay</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.codehaus.jackson</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.org.apache.avro</shadedPattern> + <shadedPattern>org.apache.hadoop.hbase.com.sun.jersey</shadedPattern> {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchReleaseAuditWarnings.txt Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13753//console This message is automatically generated. > Publish a client artifact with shaded dependencies > -------------------------------------------------- > > Key: HBASE-13517 > URL: https://issues.apache.org/jira/browse/HBASE-13517 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 1.1.0 > Reporter: Elliott Clark > Assignee: Elliott Clark > Fix For: 2.0.0, 1.1.0 > > Attachments: HBASE-13517-v1.patch, HBASE-13517-v2.patch, > HBASE-13517.patch > > > Guava's moved on. Hadoop has not. > Jackson moves whenever it feels like it. > Protobuf moves with breaking point changes. > While shading all of the time would break people that require the transitive > dependencies for MR or other things. Lets provide an artifact with our > dependencies shaded. Then users can have the choice to use the shaded version > or the non-shaded version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)