[ 
https://issues.apache.org/jira/browse/HBASE-13517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505153#comment-14505153
 ] 

Elliott Clark commented on HBASE-13517:
---------------------------------------

bq.I don't want e.g. someone who needs to use HBase and HDFS to suddenly have 
another jar with the hadoop packages visible just because they're trying to use 
our shaded artifact.

We can't relocate Hadoop because that would break Configuration and several 
public apis. However we need to include the classes because they use guava and 
need to be re-written to use the new location.

The rest of the dependencies should be relocated.

bq.nit: could we use something like org.apache.hadoop.hbase.shaded. as the 
prefix for all of these relocations so that there's a common package / 
directory for all of them?

Sure let me get that and have apache-rat clean.

> Publish a client artifact with shaded dependencies
> --------------------------------------------------
>
>                 Key: HBASE-13517
>                 URL: https://issues.apache.org/jira/browse/HBASE-13517
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13517-v1.patch, HBASE-13517-v2.patch, 
> HBASE-13517.patch
>
>
> Guava's moved on. Hadoop has not.
> Jackson moves whenever it feels like it.
> Protobuf moves with breaking point changes.
> While shading all of the time would break people that require the transitive 
> dependencies for MR or other things. Lets provide an artifact with our 
> dependencies shaded. Then users can have the choice to use the shaded version 
> or the non-shaded version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to