[ https://issues.apache.org/jira/browse/HBASE-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519339#comment-14519339 ]
Hadoop QA commented on HBASE-13579: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12728776/HBASE-13579_storelevel.patch against master branch at commit 85ac00ba9f90e570d59ec83c31e0b526be0155dd. ATTACHMENT ID: 12728776 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4 warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 1900 checkstyle errors (more than the master's current 1898 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy org.apache.hadoop.hbase.regionserver.TestStripeCompactor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13878//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13878//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13878//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13878//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13878//console This message is automatically generated. > Avoid isCellTTLExpired() for NO-TAG cases > ----------------------------------------- > > Key: HBASE-13579 > URL: https://issues.apache.org/jira/browse/HBASE-13579 > Project: HBase > Issue Type: Sub-task > Components: Scanners > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Attachments: HBASE-13579_KVExtension.patch, > HBASE-13579_storelevel.patch > > > As observed in this JIRA's performance test, we are always calling the > isCellTTLExpired() for every cell and internally it is parsing the keyLength, > valueLength() to get the tagsLength after which we decide whether Cell level > TTL is present are not. > This JIRA aims to avoid this check if all the readers of the storescanner > knows that there are no tags to read. Note that, for the memstore scanner we > will do that in another JIRA, which I suppose Stack had already raised to > avoid tag length while flushing (for the NO-TAG) case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)