[
https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120557#comment-13120557
]
jirapos...@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2327
-----------------------------------------------------------
src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
<https://reviews.apache.org/r/2029/#comment5374>
Nice
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5375>
Is this comparator needed? Without it I'd think we'd sort by the String's
"natural order" which is probably what we want?
src/main/java/org/apache/hadoop/hbase/HServerLoad.java
<https://reviews.apache.org/r/2029/#comment5376>
Are we doing this twice here? There is a getProcessors and its makes them
up on the fly. Do we need this data member?
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<https://reviews.apache.org/r/2029/#comment5377>
We don't use a Comparator here.
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/2029/#comment5379>
Could you just do masterCoprocessors.toArray here?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/2029/#comment5381>
Or do
return hsl == null? null: hsl.getCoprocessors();
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java
<https://reviews.apache.org/r/2029/#comment5386>
Can these asserts be done inside another CP test rather than in a
standalone test as here? These cluster spinups take time. No biggie if not
possible.
- Michael
On 2011-10-04 01:21:46, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-04 01:21:46)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java a55a4b1
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
dbae4fd
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java f80d232
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
3840279
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorReporting.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and
testMasterServerCoprocessorsReported() included in a new source file
src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to
> master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch,
> master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more
> generic, we need a way to report this piece of information from region to
> master (or just at region server level). So later on, we can display the
> loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
