[
https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127810#comment-13127810
]
jirapos...@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java,
line 378
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48373#file48373line378>
bq. >
bq. > can you finish the TODO?
Added more testing for loaded-coprocessor reporting as it relates to user
tables' being loaded and unloaded in testRegionServerCoprocessorsReported().
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 542
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48368#file48368line542>
bq. >
bq. > As above: Arrays.toString() can be null.
Checking for null return value from Arrays.toStrings() : thanks for catching
this.
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 448
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48368#file48368line448>
bq. >
bq. > This is cool.
bq. >
bq. > Array.toString() can return null. You want to check?
Checking for null here: thanks for catching this.
bq. On 2011-10-06 18:44:31, Mingjie Lai wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 162
bq. > <https://reviews.apache.org/r/2029/diff/8/?file=48367#file48367line162>
bq. >
bq. > masterCoprocessors is a string array. I don't think you can use
equals() here.
bq. >
bq. > If the 2 arrays are sorted, you may use Arrays.equals().
Using Arrays.equals() rather than String[].equals - you are right; thanks for
catching this.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2398
-----------------------------------------------------------
On 2011-10-14 19:50:47, Eugene Koontz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2029/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 19:50:47)
bq.
bq.
bq. Review request for hbase and Mingjie Lai.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Proposed fix for HBASE-4070.
bq.
bq.
bq. This addresses bug HBASE-4070.
bq. https://issues.apache.org/jira/browse/HBASE-4070
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. .gitignore a8a9adc
bq. conf/hbase-site.xml af4c300
bq. src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
abeb850
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
be6fceb
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd
bq. src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
7d2f82e
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
e2e694a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
eda5a9b
bq.
bq. Diff: https://reviews.apache.org/r/2029/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Two new tests : testRegionServerCoprocessorReported() and
testMasterServerCoprocessorsReported() included in a new source file
src/test/java/o.a.h.h/coprocessor/TestCoprocessorReporting.java.
bq.
bq.
bq. Thanks,
bq.
bq. Eugene
bq.
bq.
> [Coprocessors] Improve region server metrics to report loaded coprocessors to
> master
> ------------------------------------------------------------------------------------
>
> Key: HBASE-4070
> URL: https://issues.apache.org/jira/browse/HBASE-4070
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.3
> Reporter: Mingjie Lai
> Assignee: Eugene Koontz
> Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch,
> master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more
> generic, we need a way to report this piece of information from region to
> master (or just at region server level). So later on, we can display the
> loaded class names at shell as well as web console.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
