[ https://issues.apache.org/jira/browse/HBASE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551629#comment-14551629 ]
Hadoop QA commented on HBASE-13645: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12733986/HBASE-13645.patch against master branch at commit 02fa2200be4ead37094efbac74cb3431fa0ead55. ATTACHMENT ID: 12733986 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 16 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 1922 checkstyle errors (more than the master's current 1898 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster org.apache.hadoop.hbase.mapreduce.TestImportExport Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14107//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14107//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14107//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14107//console This message is automatically generated. > Rename *column methods in MasterObserver to *columnFamily > --------------------------------------------------------- > > Key: HBASE-13645 > URL: https://issues.apache.org/jira/browse/HBASE-13645 > Project: HBase > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HBASE-13645.patch, HBASE-13645.patch > > > This being an interface makes it a bit harder on implementors. It'd be easier > with Java8 and default implementations. > We could either > # add new *columnFamily methods and deprecate the old ones or > # rename the existing ones without doing a deprecation first. > Implementors would need to change their code in each of those cases. But > because we have the {{BaseMasterObserver}} and > {{BaseMasterAndRegionObserver}} it'd make things easier for people using > those classes if we go with option 1. So that's my preference. > The plan would be to add these methods in 2.0.0 and remove the old ones in > 3.0.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)