[ 
https://issues.apache.org/jira/browse/HBASE-13645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555121#comment-14555121
 ] 

Hudson commented on HBASE-13645:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6506 (See 
[https://builds.apache.org/job/HBase-TRUNK/6506/])
HBASE-13645: Rename *column methods in MasterObserver to *columnFamily (stack: 
rev d16f349a63ead7d67957564ffba37196af03a9d8)
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestTableLockManager.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java


> Rename *column methods in MasterObserver to *columnFamily
> ---------------------------------------------------------
>
>                 Key: HBASE-13645
>                 URL: https://issues.apache.org/jira/browse/HBASE-13645
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13645 (1).patch, HBASE-13645.patch, 
> HBASE-13645.patch
>
>
> This being an interface makes it a bit harder on implementors. It'd be easier 
> with Java8 and default implementations.
> We could either
> # add new *columnFamily methods and deprecate the old ones or
> # rename the existing ones without doing a deprecation first.
> Implementors would need to change their code in each of those cases. But 
> because we have the {{BaseMasterObserver}} and 
> {{BaseMasterAndRegionObserver}} it'd make things easier for people using 
> those classes if we go with option 1. So that's my preference.
> The plan would be to add these methods in 2.0.0 and remove the old ones in 
> 3.0.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to