[ 
https://issues.apache.org/jira/browse/HBASE-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642559#comment-14642559
 ] 

stack commented on HBASE-14063:
-------------------------------

Should ByteBufferedKeyOnlyKeyValue be called ByteBufferedKey? Or ByteBufferKey. 
The former is a mouthful. Could be done in a followup issue.

Is this for serialization only?

40        public ByteBufferedKeyOnlyKeyValue() {
41        }

Add a comment if so on commit.

Why we have to have a OffheapKeyValue? What makes it different from a KV other 
than the assert that it is backed by direct bytebuffer?

This is threadsafe? Won't have two threads concurrently trying to do this?

                bufBackedKeyOnlyKv.setKey(pair.getFirst(), pair.getSecond(), 
klen);



> Use BufferBackedCell in read path after HBASE-12213 and HBASE-12295
> -------------------------------------------------------------------
>
>                 Key: HBASE-14063
>                 URL: https://issues.apache.org/jira/browse/HBASE-14063
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14063.patch, HBASE-14063_1.patch, 
> HBASE-14063_3.patch, HBASE-14063_final.patch
>
>
> Subtask to ensure that the BytebufferBackedCell gets used in the read path 
> after HBASE-12213 and HBASE-12295 goes in.  This would help to clearly change 
> the required places and makes the review easier. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to