[ 
https://issues.apache.org/jira/browse/HBASE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131133#comment-13131133
 ] 

jirapos...@reviews.apache.org commented on HBASE-4070:
------------------------------------------------------



bq.  On 2011-10-19 21:34:00, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/HServerLoad.java, line 78
bq.  > <https://reviews.apache.org/r/2029/diff/11/?file=50347#file50347line78>
bq.  >
bq.  >     Is this a 'load'?  Or is this an attribute of the server?   We used 
to have an HServerInfo.  This looks like something that would belong in there 
rather than in HSL?

Hi Michael,

As Ted mentioned, HServerInfo is deprecated (per 
https://issues.apache.org/jira/browse/HBASE-1502) .


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2029/#review2678
-----------------------------------------------------------


On 2011-10-16 16:22:16, Eugene Koontz wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2029/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-16 16:22:16)
bq.  
bq.  
bq.  Review request for hbase and Mingjie Lai.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Proposed fix for HBASE-4070. 
bq.  
bq.  
bq.  This addresses bug HBASE-4070.
bq.      https://issues.apache.org/jira/browse/HBASE-4070
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon 
abeb850 
bq.    src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 
be6fceb 
bq.    src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 01bc1dd 
bq.    src/main/java/org/apache/hadoop/hbase/HServerLoad.java 0c680e4 
bq.    src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 92c959c 
bq.    src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 
7d2f82e 
bq.    src/main/java/org/apache/hadoop/hbase/master/HMaster.java 50b49a6 
bq.    src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
e2e694a 
bq.    src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 
eda5a9b 
bq.  
bq.  Diff: https://reviews.apache.org/r/2029/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Two new tests : testRegionServerCoprocessorReported() and 
testMasterServerCoprocessorsReported() added to (existing) 
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Eugene
bq.  
bq.


                
> [Coprocessors] Improve region server metrics to report loaded coprocessors to 
> master
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-4070
>                 URL: https://issues.apache.org/jira/browse/HBASE-4070
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.3
>            Reporter: Mingjie Lai
>            Assignee: Eugene Koontz
>         Attachments: HBASE-4070.patch, HBASE-4070.patch, HBASE-4070.patch, 
> HBASE-4070.patch, master-web-ui.jpg, rs-status-web-ui.jpg
>
>
> HBASE-3512 is about listing loaded cp classes at shell. To make it more 
> generic, we need a way to report this piece of information from region to 
> master (or just at region server level). So later on, we can display the 
> loaded class names at shell as well as web console. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to