[ 
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135697#comment-13135697
 ] 

Ted Yu commented on HBASE-4669:
-------------------------------

Do we have to introduce assignUserRegionsToOnlineServers() ?
We already have:
{code}
  public void assignUserRegions(List<HRegionInfo> regions, List<ServerName> 
servers)
{code}

I don't think IOE should be swallowed:
{code}
+        try {
+          assignmentManager.assignUserRegionsToOnlineServers(regions);
+        } catch (IOException e) {
+          LOG.error("Error while assigning user regions to online servers", e);
+        } catch (InterruptedException e) {
{code}

Please add javadoc for the new unit test.

Publishing on reviewboard would allow more people to comment.
                
> Add an option of using round-robin assignment for enabling table
> ----------------------------------------------------------------
>
>                 Key: HBASE-4669
>                 URL: https://issues.apache.org/jira/browse/HBASE-4669
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.90.4, 0.94.0
>            Reporter: Jieshan Bean
>            Priority: Minor
>             Fix For: 0.94.0, 0.90.5
>
>         Attachments: HBASE-4669-Trunk.patch
>
>
> Under some scenarios, we use the function of disable/enable HTable. But 
> currently, enable HTable uses the random-assignment. We hope all the regions 
> show a better distribution, no matter how many regions and how many 
> regionservers.
> So I suggest to add an option of using round-robin assignment on 
> enable-table. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to